Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.x] Fix unittest link flags for extra micro-arch; fix private header #9171

Merged
merged 2 commits into from
May 2, 2024

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented May 1, 2024

backport of #9170
also contains backport of #9172

@smuzaffar
Copy link
Contributor Author

test parameters:

  • addpkg = FWCore/Framework

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2024

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_0_X/master.

@cmsbuild, @iarspider, @smuzaffar, @aandvalenzuela can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_14_0_MULTIARCHS_X

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-932e8a/39198/summary.html
COMMIT: ec3649f
CMSSW: CMSSW_14_0_X_2024-05-01-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9171/39198/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smuzaffar smuzaffar changed the title [14.0.x] Fix unittest link flags for extra micro-arch [14.0.x] Fix unittest link flags for extra micro-arch; fix private header May 2, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2024

Pull request #9171 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_14_0_MULTIARCHS_X

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-932e8a/39209/summary.html
COMMIT: 515674b
CMSSW: CMSSW_14_0_X_2024-05-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9171/39209/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar smuzaffar merged commit ec4ee22 into IB/CMSSW_14_0_X/master May 2, 2024
15 of 16 checks passed
@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2024

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-932e8a/39210/summary.html
COMMIT: 515674b
CMSSW: CMSSW_14_0_MULTIARCHS_X_2024-05-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9171/39210/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 370 lines from the logs
  • Reco comparison results: 71276 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3326485
  • DQMHistoTests: Total failures: 160206
  • DQMHistoTests: Total nulls: 280
  • DQMHistoTests: Total successes: 3165979
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -5.81 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.127 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): -0.695 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 140.043,... ): -0.016 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 140.063 ): -0.070 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): 0.086 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.046 ): 0.016 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): -1.135 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.671 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 0.105 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): -4.883 KiB SiStrip/MechanicalView
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 15 / 46 workflows

@smuzaffar smuzaffar deleted the 140x-9170 branch May 8, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants